Skip to content

Changes

Summary

  1. Set Evaluate = true for IdealTransformer.considerMagnetization (details)
  2. refs #4093 Add CMake configuration as PoC (details)
Commit 54c07f297f984e404e79b4dccd7a4cb0eff4f3dd by modelica
Set Evaluate = true for IdealTransformer.considerMagnetization

Leaving this parameter unevaluated seems like making things overly complicated, and as far as I can see there is nothing that clearly requires the parameter to be treated structurally.  Hence, adding an explicit annotation will increase chances of models being treated equally efficiently across tools.

Of course, I would have preferred to declare considerMagnetization a constant with Dialog annotation instead, but I'm afraid the general preference is to use a parameter with Evaluate = true instead.
The file was modified Modelica/Electrical/Analog/Ideal/IdealTransformer.mo (diff)
Commit 8dd8a4af24a6d3dc6e009bd667b5141cabfb7f78 by modelica
refs #4093 Add CMake configuration as PoC
The file was addedModelica/Resources/BuildProjects/CMake/CMakeLists.txt

Summary

  1. Set Evaluate = true for IdealTransformer.considerMagnetization (details)
  2. refs #4093 Add CMake configuration as PoC (details)
Commit 54c07f297f984e404e79b4dccd7a4cb0eff4f3dd by modelica
Set Evaluate = true for IdealTransformer.considerMagnetization

Leaving this parameter unevaluated seems like making things overly complicated, and as far as I can see there is nothing that clearly requires the parameter to be treated structurally.  Hence, adding an explicit annotation will increase chances of models being treated equally efficiently across tools.

Of course, I would have preferred to declare considerMagnetization a constant with Dialog annotation instead, but I'm afraid the general preference is to use a parameter with Evaluate = true instead.
The file was modified Modelica/Electrical/Analog/Ideal/IdealTransformer.mo (diff)
Commit 8dd8a4af24a6d3dc6e009bd667b5141cabfb7f78 by modelica
refs #4093 Add CMake configuration as PoC
The file was addedModelica/Resources/BuildProjects/CMake/CMakeLists.txt

Summary

  1. Set Evaluate = true for IdealTransformer.considerMagnetization (details)
  2. refs #4093 Add CMake configuration as PoC (details)
Commit 54c07f297f984e404e79b4dccd7a4cb0eff4f3dd by modelica
Set Evaluate = true for IdealTransformer.considerMagnetization

Leaving this parameter unevaluated seems like making things overly complicated, and as far as I can see there is nothing that clearly requires the parameter to be treated structurally.  Hence, adding an explicit annotation will increase chances of models being treated equally efficiently across tools.

Of course, I would have preferred to declare considerMagnetization a constant with Dialog annotation instead, but I'm afraid the general preference is to use a parameter with Evaluate = true instead.
The file was modified Modelica/Electrical/Analog/Ideal/IdealTransformer.mo (diff)
Commit 8dd8a4af24a6d3dc6e009bd667b5141cabfb7f78 by modelica
refs #4093 Add CMake configuration as PoC
The file was addedModelica/Resources/BuildProjects/CMake/CMakeLists.txt