Changes

Summary

Use boolean array reductions (#3919) (details)
Remove unused code (#3622) (#3623) (details)
Generate events in functions; to avoid non-discrete booleans. (details)
Apply suggestions from code review (details)
Need Inline as well (at least for Dymola - and shouldn't be problem). (details)
Add test-case (details)
Update ModelicaTest/Media.mo (details)

Commit ceae18716d2b21285b1d3fb81328794968252250 by noreply Use boolean array reductions (#3919) * Change description of allTrue to show difference compared to andTrue * Use Boolean array reductions in some BooleanVectors functions This takes advantages of tools' dedicated implementations of conjunction and disjunction of multiple values expressed as Boolean array reduction with min and max, respectively. With the result being given by simple expressions, it seemed natural to also set Inline = true. * Remove empty algorithm Addressing review comment by @beutlich. * Remove empty algorithm * Remove empty algorithm As suggested by @beutlich.
The file was modified	Modelica/Math/BooleanVectors.mo (diff)
Commit 5fe4ebd813a2c723a712af477d61253f44b00d79 by noreply Remove unused code (#3622) (#3623) * remove unused code #3622 * Keep protected parameters in blocks and models, not in functions * Add alternative implementation in FromSpacePhasor.mo Add alternative implementation comment and revert comment removal for those implementation * add alternative implementation comment in Rotator.mo Add alternative implementation comment and revert comment removal for those implementation * Add alternative implementation comment in ToSpacePhasor.mo Add alternative implementation comment and revert comment removal for those implementation * add alternative implementation comment in Rotator.mo Add alternative implementation comment and revert comment removal for those implementation * add alternative implementation comment in SpacePhasor.mo Add alternative implementation comment and revert comment removal for those implementation --------- Co-authored-by: Christian Kral <dr.christian.kral@gmail.com> Co-authored-by: arunkumar-narasimhan <124154466+arunkumar-narasimhan@users.noreply.github.com>
The file was modified	Modelica/Electrical/Machines/SpacePhasors/Blocks/Rotator.mo (diff)
The file was modified	Modelica/Electrical/Machines/SpacePhasors/Blocks/ToSpacePhasor.mo (diff)
The file was modified	Modelica/Electrical/Machines/SpacePhasors/Components/SpacePhasor.mo (diff)
The file was modified	Modelica/Electrical/Machines/SpacePhasors/Components/Rotator.mo (diff)
The file was modified	Modelica/Electrical/Machines/SpacePhasors/Blocks/FromSpacePhasor.mo (diff)
The file was modified	Modelica/Electrical/Machines/SpacePhasors/Functions/FromSpacePhasor.mo (diff)
The file was modified	Modelica/Electrical/Machines/SpacePhasors/Functions/ToSpacePhasor.mo (diff)
Commit 8dbbf55f9b13323617e95917b55c4e79183b94cf by modelica Generate events in functions; to avoid non-discrete booleans. Closes #4209
The file was modified	Modelica/Media/R134a.mo (diff)
Commit 67131f3231b61f80cf535b43e31d740a32e1b3c6 by modelica Apply suggestions from code review Fix annotations. Co-authored-by: Thomas Beutlich <modelica@tbeu.de>
The file was modified	Modelica/Media/R134a.mo (diff)
Commit 0f50d9855bcce0c83582bd46070cc95478515522 by modelica Need Inline as well (at least for Dymola - and shouldn't be problem).
The file was modified	Modelica/Media/R134a.mo (diff)
Commit 03af0d9aca575414a91e1f7529c2f781342753c7 by modelica Add test-case
The file was modified	ModelicaTest/Media.mo (diff)
The file was added	ModelicaTest/Resources/Reference/ModelicaTest/Media/TestOnly/R134a_setState_phX/comparisonSignals.txt
Commit 47d580291b51b2a17148d163223372c4f73c0aa4 by modelica Update ModelicaTest/Media.mo Co-authored-by: Thomas Beutlich <modelica@tbeu.de>
The file was modified	ModelicaTest/Media.mo (diff)