Changes

Fix unit error in SimpleLiquidWater model

Express the pressure rate in relation to Pa / bar conversion.

Co-authored-by: Hans Olsson <HansOlsson@users.noreply.github.com>

Fix unit error in TestOnly.MoistAir

Note that there is currently no Units.SI.PressureRate.

Fix R134a_setState_pTX and WaterIF97_dewEnthalpy in the same way

Fix unit error in Thyristor

Introduces a variable to resolve a unit error in an equation.

Add Friction test to ModelicaTest.Translational package

Fix position prescribed friction for both moving directions

Add more test models

Add failing test for Rotational Friction

Fix position prescribed rotational friction for both moving directions

Avoid having both start-value and initial equation.

Use mustBeConnected annotation (introduced in Modelica 3.6) for all conditional support connectors.

Proper word

Implement improvement suggested by @tobolar

User's Guide: add recommendation for 'tab' and 'group' annotations

Documentation: clarify mind-set of planar rotation

Improve EN grammar

Co-authored-by: Hans Olsson <HansOlsson@users.noreply.github.com>

Add a rule priorizing the 'general' tab

Add example how to define tab and group annotations

Enhance the 'Tabs and Groups' example

Add ZeroThresholds test

Update Modelica/Media/package.mo

Co-authored-by: Henrik Tidefelt <henrikt@wolfram.com>

Fix unit errors in Examples.MoistAir

Fix unit error in IdealGasH2O

Fix unit errors in ReferenceAir.MoistAir

Make the new variable a parameter as it is more idiomatic.

Co-authored-by: Hans Olsson <HansOlsson@users.noreply.github.com>

Use mustBeConnected annotation (introduced in Modelica 3.6) for all conditional support connectors.

Proper word

Avoid having both start-value and initial equation.

Improve ElastoGap
Closes #4197

Prefer code to pre, and move things.

Add scaling ratio variable and add parameter description

Simplify computation of f_d

Documentation: add non-braking spaces where needed

Add scaling ratio variable and add parameter description

Simplify computation of f_d

Documentation: add non-braking spaces where needed

Improve documentation concerning s_rel and f_rel

Enable only positive values of s_rel and f_rel

- added partial massFraction to partialMedium
- implemented massFraction for partialPureSubstance
- implemented massFraction for PartialMixtureMedium
- added 3 test cases for ModeliceTest covering pure / reduced mixture / non-reduced misture

Update Modelica/Media/package.mo

Accepted suggestion

Co-authored-by: Thomas Beutlich <modelica@tbeu.de>

Use spaces instead of tabs

Bump used Modelica language version to 3.6 (#4208)

* Bump used Modelica language version to 3.6

* Fix bad &nbsp>

Detected by html_documentation_checks.

* Skip main entry when linking to getInstanceName in specification

* Re-trigger CI checks

A value with unit="1" should not have a time as start-value
Closes #4054

Time events instead of state events

Replace "discrete input" by just "input"
https://github.com/modelica/ModelicaSpecification/issues/3220

Remove unused functions (#4061)

Note that they were previously used by get_token which was removed in #3783

Update .mailmap file

Create by command

```
git log --raw | grep "^Author: " | sort | uniq | cut -d ' ' -f2- | sed 's/^//' > .mailmap
```

Upgrade zlib to v1.2.13 (#4047)

Take care to not break #3787 again.

Fix typo (#4249)

Some generic Formatting guides - consistent with how classes are usually written.

Use protected as a heading for a number of declarations.
I believe that the previous formatting in Digitial is due to someone having
protected A
protected B
protected C
(which would be another style).
Then the subsequent protected were lost, and first protected formatted on a separate line.

Avoid bad line-breaks in connect-annotation.

Do not use tab.
(Additional changes would be good.)

Remove trailing white-space

The end of a class shall not be indented relative to class.

RemoveTrailingWhiteSpace

NoTab

Even for redeclare extends ensure that class contents is indented relative to class.

Indent annotation relative to class

Documentation shall be indented relative to class

And sensible formatting

Use protected as heading consistently.

Remove weird line-breaks and format equation consistently.

Add separation rule as well.

And apply the rule

Update Modelica/Electrical/Machines/Sensors/CurrentQuasiRMSSensor.mo

Apply suggestions from code review

Co-authored-by: Henrik Tidefelt <henrikt@wolfram.com>

Apply suggestions from code review

Minor formatting changes in html code

Apply suggestions from code review

Co-authored-by: tobolar <tobolar@users.noreply.github.com>

Specify how to handle modifier lists.
Give example.

Rename to be slightly better.

Quoting!

Type Modelica keywords in bold and remove trailing whitespaces ;-)

TrailingWhiteSpace

TrailingWhiteSpaceOnEmptyLine

Revert "Fix position prescribed friction"

Revert "Merge pull request #4255 from modelica/revert-4129-fix-friction"

This reverts commit ee5fae81b6402cf15ffa6e365fdc7de0554ddb57, reversing
changes made to ae7afdc273639fdc0f99030e7444d44ac729d073.

Enhance a_relfric for forward/backward sliding

Fix missing simulation time

Co-authored-by: Hans Olsson <HansOlsson@users.noreply.github.com>

Use Vector for visualization of forces and torques

Use Vector for visualization of positions in Sensors and Joints

Use Vector for visualization

Update .mailmap file

Create by command

```
git log --raw | grep "^Author: " | sort | uniq | cut -d ' ' -f2- | sed 's/^//' > .mailmap
```

resolves issue #4245

Set Evaluate = true for IdealTransformer.considerMagnetization

Leaving this parameter unevaluated seems like making things overly complicated, and as far as I can see there is nothing that clearly requires the parameter to be treated structurally.  Hence, adding an explicit annotation will increase chances of models being treated equally efficiently across tools.

Of course, I would have preferred to declare considerMagnetization a constant with Dialog annotation instead, but I'm afraid the general preference is to use a parameter with Evaluate = true instead.

Partially revert 18320a68b295c9b0be7a5fade0420487ec0059dc (#4252)

Add badges for regression tests run by LTX (#4212)

Make third-party licenses explicit (#4268)

Utilize PressureSlope unit in Media consistently (#4262)

* Utilize PressureRate unit

* Rename PressureRate to PressureSlope

Fix loss factors in SharpEdgedOrifice (#4258)

Co-authored-by: Stefan Wischhusen <wischhusen@xrg-simulation.de>

Add ModelicaDuplicateString and ModelicaDuplicateStringWithErrorReturn (new in Modelica Language Specification version 3.5) (#3686)

* Add ModelicaDuplicateString and ModelicaDuplicateStringWithErrorReturn

* Utilize ModelicaDuplicateString and ModelicaDuplicateStringWithErrorReturn

* Rename format specifying arguments

* Utilize ModelicaDuplicateString and ModelicaDuplicateStringWithErrorReturn

* Rely on assert

Co-authored-by: Henrik Tidefelt <henrikt@wolfram.com>

* Update spelling

Co-authored-by: Henrik Tidefelt <henrikt@wolfram.com>

* Call ModelicaError as stated in MLS 12.9.6.2

---------

Co-authored-by: Henrik Tidefelt <henrikt@wolfram.com>

Fix unit error in SimpleLiquidWater model

Express the pressure rate in relation to Pa / bar conversion.

Co-authored-by: Hans Olsson <HansOlsson@users.noreply.github.com>

Fix unit error in TestOnly.MoistAir

Note that there is currently no Units.SI.PressureRate.

Fix R134a_setState_pTX and WaterIF97_dewEnthalpy in the same way

Fix unit error in Thyristor

Introduces a variable to resolve a unit error in an equation.

Add Friction test to ModelicaTest.Translational package

Fix position prescribed friction for both moving directions

Add more test models

Add failing test for Rotational Friction

Fix position prescribed rotational friction for both moving directions

Avoid having both start-value and initial equation.

Use mustBeConnected annotation (introduced in Modelica 3.6) for all conditional support connectors.

Proper word

Implement improvement suggested by @tobolar

User's Guide: add recommendation for 'tab' and 'group' annotations

Documentation: clarify mind-set of planar rotation

Improve EN grammar

Co-authored-by: Hans Olsson <HansOlsson@users.noreply.github.com>

Add a rule priorizing the 'general' tab

Add example how to define tab and group annotations

Enhance the 'Tabs and Groups' example

Add ZeroThresholds test

Update Modelica/Media/package.mo

Co-authored-by: Henrik Tidefelt <henrikt@wolfram.com>

Fix unit errors in Examples.MoistAir

Fix unit error in IdealGasH2O

Fix unit errors in ReferenceAir.MoistAir

Make the new variable a parameter as it is more idiomatic.

Co-authored-by: Hans Olsson <HansOlsson@users.noreply.github.com>

Use mustBeConnected annotation (introduced in Modelica 3.6) for all conditional support connectors.

Proper word

Avoid having both start-value and initial equation.

Improve ElastoGap
Closes #4197

Prefer code to pre, and move things.

Add scaling ratio variable and add parameter description

Simplify computation of f_d

Documentation: add non-braking spaces where needed

Add scaling ratio variable and add parameter description

Simplify computation of f_d

Documentation: add non-braking spaces where needed

Improve documentation concerning s_rel and f_rel

Enable only positive values of s_rel and f_rel

- added partial massFraction to partialMedium
- implemented massFraction for partialPureSubstance
- implemented massFraction for PartialMixtureMedium
- added 3 test cases for ModeliceTest covering pure / reduced mixture / non-reduced misture

Update Modelica/Media/package.mo

Accepted suggestion

Co-authored-by: Thomas Beutlich <modelica@tbeu.de>

Use spaces instead of tabs

Bump used Modelica language version to 3.6 (#4208)

* Bump used Modelica language version to 3.6

* Fix bad &nbsp>

Detected by html_documentation_checks.

* Skip main entry when linking to getInstanceName in specification

* Re-trigger CI checks

A value with unit="1" should not have a time as start-value
Closes #4054

Time events instead of state events

Replace "discrete input" by just "input"
https://github.com/modelica/ModelicaSpecification/issues/3220

Remove unused functions (#4061)

Note that they were previously used by get_token which was removed in #3783

Update .mailmap file

Create by command

```
git log --raw | grep "^Author: " | sort | uniq | cut -d ' ' -f2- | sed 's/^//' > .mailmap
```

Upgrade zlib to v1.2.13 (#4047)

Take care to not break #3787 again.

Fix typo (#4249)

Some generic Formatting guides - consistent with how classes are usually written.

Use protected as a heading for a number of declarations.
I believe that the previous formatting in Digitial is due to someone having
protected A
protected B
protected C
(which would be another style).
Then the subsequent protected were lost, and first protected formatted on a separate line.

Avoid bad line-breaks in connect-annotation.

Do not use tab.
(Additional changes would be good.)

Remove trailing white-space

The end of a class shall not be indented relative to class.

RemoveTrailingWhiteSpace

NoTab

Even for redeclare extends ensure that class contents is indented relative to class.

Indent annotation relative to class

Documentation shall be indented relative to class

And sensible formatting

Use protected as heading consistently.

Remove weird line-breaks and format equation consistently.

Add separation rule as well.

And apply the rule

Update Modelica/Electrical/Machines/Sensors/CurrentQuasiRMSSensor.mo

Apply suggestions from code review

Co-authored-by: Henrik Tidefelt <henrikt@wolfram.com>

Apply suggestions from code review

Minor formatting changes in html code

Apply suggestions from code review

Co-authored-by: tobolar <tobolar@users.noreply.github.com>

Specify how to handle modifier lists.
Give example.

Rename to be slightly better.

Quoting!

Type Modelica keywords in bold and remove trailing whitespaces ;-)

TrailingWhiteSpace

TrailingWhiteSpaceOnEmptyLine

Revert "Fix position prescribed friction"

Revert "Merge pull request #4255 from modelica/revert-4129-fix-friction"

This reverts commit ee5fae81b6402cf15ffa6e365fdc7de0554ddb57, reversing
changes made to ae7afdc273639fdc0f99030e7444d44ac729d073.

Enhance a_relfric for forward/backward sliding

Fix missing simulation time

Co-authored-by: Hans Olsson <HansOlsson@users.noreply.github.com>

Use Vector for visualization of forces and torques

Use Vector for visualization of positions in Sensors and Joints

Use Vector for visualization

Update .mailmap file

Create by command

```
git log --raw | grep "^Author: " | sort | uniq | cut -d ' ' -f2- | sed 's/^//' > .mailmap
```

resolves issue #4245

Set Evaluate = true for IdealTransformer.considerMagnetization

Leaving this parameter unevaluated seems like making things overly complicated, and as far as I can see there is nothing that clearly requires the parameter to be treated structurally.  Hence, adding an explicit annotation will increase chances of models being treated equally efficiently across tools.

Of course, I would have preferred to declare considerMagnetization a constant with Dialog annotation instead, but I'm afraid the general preference is to use a parameter with Evaluate = true instead.

Partially revert 18320a68b295c9b0be7a5fade0420487ec0059dc (#4252)

Add badges for regression tests run by LTX (#4212)

Make third-party licenses explicit (#4268)

Utilize PressureSlope unit in Media consistently (#4262)

* Utilize PressureRate unit

* Rename PressureRate to PressureSlope

Fix loss factors in SharpEdgedOrifice (#4258)

Co-authored-by: Stefan Wischhusen <wischhusen@xrg-simulation.de>

Add ModelicaDuplicateString and ModelicaDuplicateStringWithErrorReturn (new in Modelica Language Specification version 3.5) (#3686)

* Add ModelicaDuplicateString and ModelicaDuplicateStringWithErrorReturn

* Utilize ModelicaDuplicateString and ModelicaDuplicateStringWithErrorReturn

* Rename format specifying arguments

* Utilize ModelicaDuplicateString and ModelicaDuplicateStringWithErrorReturn

* Rely on assert

Co-authored-by: Henrik Tidefelt <henrikt@wolfram.com>

* Update spelling

Co-authored-by: Henrik Tidefelt <henrikt@wolfram.com>

* Call ModelicaError as stated in MLS 12.9.6.2

---------

Co-authored-by: Henrik Tidefelt <henrikt@wolfram.com>

Fix unit error in SimpleLiquidWater model

Express the pressure rate in relation to Pa / bar conversion.

Co-authored-by: Hans Olsson <HansOlsson@users.noreply.github.com>

Fix unit error in TestOnly.MoistAir

Note that there is currently no Units.SI.PressureRate.

Fix R134a_setState_pTX and WaterIF97_dewEnthalpy in the same way

Fix unit error in Thyristor

Introduces a variable to resolve a unit error in an equation.

Add Friction test to ModelicaTest.Translational package

Fix position prescribed friction for both moving directions

Add more test models

Add failing test for Rotational Friction

Fix position prescribed rotational friction for both moving directions

Avoid having both start-value and initial equation.

Use mustBeConnected annotation (introduced in Modelica 3.6) for all conditional support connectors.

Proper word

Implement improvement suggested by @tobolar

User's Guide: add recommendation for 'tab' and 'group' annotations

Documentation: clarify mind-set of planar rotation

Improve EN grammar

Co-authored-by: Hans Olsson <HansOlsson@users.noreply.github.com>

Add a rule priorizing the 'general' tab

Add example how to define tab and group annotations

Enhance the 'Tabs and Groups' example

Add ZeroThresholds test

Update Modelica/Media/package.mo

Co-authored-by: Henrik Tidefelt <henrikt@wolfram.com>

Fix unit errors in Examples.MoistAir

Fix unit error in IdealGasH2O

Fix unit errors in ReferenceAir.MoistAir

Make the new variable a parameter as it is more idiomatic.

Co-authored-by: Hans Olsson <HansOlsson@users.noreply.github.com>

Use mustBeConnected annotation (introduced in Modelica 3.6) for all conditional support connectors.

Proper word

Avoid having both start-value and initial equation.

Improve ElastoGap
Closes #4197

Prefer code to pre, and move things.

Add scaling ratio variable and add parameter description

Simplify computation of f_d

Documentation: add non-braking spaces where needed

Add scaling ratio variable and add parameter description

Simplify computation of f_d

Documentation: add non-braking spaces where needed

Improve documentation concerning s_rel and f_rel

Enable only positive values of s_rel and f_rel

- added partial massFraction to partialMedium
- implemented massFraction for partialPureSubstance
- implemented massFraction for PartialMixtureMedium
- added 3 test cases for ModeliceTest covering pure / reduced mixture / non-reduced misture

Update Modelica/Media/package.mo

Accepted suggestion

Co-authored-by: Thomas Beutlich <modelica@tbeu.de>

Use spaces instead of tabs

Bump used Modelica language version to 3.6 (#4208)

* Bump used Modelica language version to 3.6

* Fix bad &nbsp>

Detected by html_documentation_checks.

* Skip main entry when linking to getInstanceName in specification

* Re-trigger CI checks

A value with unit="1" should not have a time as start-value
Closes #4054

Time events instead of state events

Replace "discrete input" by just "input"
https://github.com/modelica/ModelicaSpecification/issues/3220

Remove unused functions (#4061)

Note that they were previously used by get_token which was removed in #3783

Update .mailmap file

Create by command

```
git log --raw | grep "^Author: " | sort | uniq | cut -d ' ' -f2- | sed 's/^//' > .mailmap
```

Upgrade zlib to v1.2.13 (#4047)

Take care to not break #3787 again.