Skip to content

Changes

Summary

  1. Set Evaluate = true for IdealTransformer.considerMagnetization (details)
  2. Make third-party licenses explicit (#4268) (details)
  3. Utilize PressureSlope unit in Media consistently (#4262) (details)
  4. Fix loss factors in SharpEdgedOrifice (#4258) (details)
  5. Rely on assert (details)
Commit 54c07f297f984e404e79b4dccd7a4cb0eff4f3dd by modelica
Set Evaluate = true for IdealTransformer.considerMagnetization

Leaving this parameter unevaluated seems like making things overly complicated, and as far as I can see there is nothing that clearly requires the parameter to be treated structurally.  Hence, adding an explicit annotation will increase chances of models being treated equally efficiently across tools.

Of course, I would have preferred to declare considerMagnetization a constant with Dialog annotation instead, but I'm afraid the general preference is to use a parameter with Evaluate = true instead.
The file was modified Modelica/Electrical/Analog/Ideal/IdealTransformer.mo (diff)
Commit 80b9eed0f27068d9b368b7b1a6244587bd1b6a25 by noreply
Make third-party licenses explicit (#4268)

The file was removedModelica/Resources/Licenses/LICENSE_portable-snippets.txt
The file was addedModelica/Resources/Licenses/Third-party/LICENSE_c99-snprintf.txt
The file was addedModelica/Resources/Licenses/Third-party/LICENSE_portable-snippets.txt
The file was removedModelica/Resources/Licenses/LICENSE_c99-snprintf.txt
The file was addedModelica/Resources/Licenses/Third-party/LICENSE_uthash.txt
The file was addedModelica/Resources/Licenses/Third-party/LICENSE_APHashFunction.txt
The file was removedModelica/Resources/Licenses/LICENSE_APHashFunction.txt
The file was addedModelica/Resources/Licenses/Third-party/LICENSE_stdint_msvc.txt
The file was removedModelica/Resources/Licenses/LICENSE_zlib.txt
The file was removedModelica/Resources/Licenses/LICENSE_win32_dirent.txt
The file was removedModelica/Resources/Licenses/LICENSE_stdint_msvc.txt
The file was removedModelica/Resources/Licenses/LICENSE_uthash.txt
The file was addedModelica/Resources/Licenses/Third-party/LICENSE_zlib.txt
The file was addedModelica/Resources/Licenses/Third-party/LICENSE_win32_dirent.txt
Commit fa90ce72720e3ffee385d1f5ab6081eb43637a94 by noreply
Utilize PressureSlope unit in Media consistently (#4262)

* Utilize PressureRate unit

* Rename PressureRate to PressureSlope
The file was modified Modelica/Media/Water/IF97_Utilities.mo (diff)
The file was modified Modelica/Media/package.mo (diff)
The file was modified Modelica/Units.mo (diff)
The file was modified Modelica/Media/Air/MoistAir.mo (diff)
Commit 68aa65640185537cd566c3739bbe81fd339651cb by noreply
Fix loss factors in SharpEdgedOrifice (#4258)

Co-authored-by: Stefan Wischhusen <wischhusen@xrg-simulation.de>
The file was modified Modelica/Fluid/Fittings.mo (diff)
Commit 0ab7e41a401444bc9a7f01264a0b4087044a0b2c by noreply
Rely on assert

Co-authored-by: Henrik Tidefelt <henrikt@wolfram.com>
The file was modified .CI/Test/Common.c (diff)

Summary

  1. Set Evaluate = true for IdealTransformer.considerMagnetization (details)
  2. Make third-party licenses explicit (#4268) (details)
  3. Utilize PressureSlope unit in Media consistently (#4262) (details)
  4. Fix loss factors in SharpEdgedOrifice (#4258) (details)
  5. Rely on assert (details)
Commit 54c07f297f984e404e79b4dccd7a4cb0eff4f3dd by modelica
Set Evaluate = true for IdealTransformer.considerMagnetization

Leaving this parameter unevaluated seems like making things overly complicated, and as far as I can see there is nothing that clearly requires the parameter to be treated structurally.  Hence, adding an explicit annotation will increase chances of models being treated equally efficiently across tools.

Of course, I would have preferred to declare considerMagnetization a constant with Dialog annotation instead, but I'm afraid the general preference is to use a parameter with Evaluate = true instead.
The file was modified Modelica/Electrical/Analog/Ideal/IdealTransformer.mo (diff)
Commit 80b9eed0f27068d9b368b7b1a6244587bd1b6a25 by noreply
Make third-party licenses explicit (#4268)

The file was removedModelica/Resources/Licenses/LICENSE_portable-snippets.txt
The file was removedModelica/Resources/Licenses/LICENSE_zlib.txt
The file was removedModelica/Resources/Licenses/LICENSE_uthash.txt
The file was addedModelica/Resources/Licenses/Third-party/LICENSE_zlib.txt
The file was addedModelica/Resources/Licenses/Third-party/LICENSE_APHashFunction.txt
The file was removedModelica/Resources/Licenses/LICENSE_c99-snprintf.txt
The file was removedModelica/Resources/Licenses/LICENSE_win32_dirent.txt
The file was addedModelica/Resources/Licenses/Third-party/LICENSE_stdint_msvc.txt
The file was removedModelica/Resources/Licenses/LICENSE_APHashFunction.txt
The file was addedModelica/Resources/Licenses/Third-party/LICENSE_uthash.txt
The file was addedModelica/Resources/Licenses/Third-party/LICENSE_c99-snprintf.txt
The file was addedModelica/Resources/Licenses/Third-party/LICENSE_win32_dirent.txt
The file was removedModelica/Resources/Licenses/LICENSE_stdint_msvc.txt
The file was addedModelica/Resources/Licenses/Third-party/LICENSE_portable-snippets.txt
Commit fa90ce72720e3ffee385d1f5ab6081eb43637a94 by noreply
Utilize PressureSlope unit in Media consistently (#4262)

* Utilize PressureRate unit

* Rename PressureRate to PressureSlope
The file was modified Modelica/Media/Air/MoistAir.mo (diff)
The file was modified Modelica/Media/package.mo (diff)
The file was modified Modelica/Media/Water/IF97_Utilities.mo (diff)
The file was modified Modelica/Units.mo (diff)
Commit 68aa65640185537cd566c3739bbe81fd339651cb by noreply
Fix loss factors in SharpEdgedOrifice (#4258)

Co-authored-by: Stefan Wischhusen <wischhusen@xrg-simulation.de>
The file was modified Modelica/Fluid/Fittings.mo (diff)
Commit 0ab7e41a401444bc9a7f01264a0b4087044a0b2c by noreply
Rely on assert

Co-authored-by: Henrik Tidefelt <henrikt@wolfram.com>
The file was modified .CI/Test/Common.c (diff)

Summary

  1. Set Evaluate = true for IdealTransformer.considerMagnetization (details)
  2. Make third-party licenses explicit (#4268) (details)
  3. Utilize PressureSlope unit in Media consistently (#4262) (details)
  4. Fix loss factors in SharpEdgedOrifice (#4258) (details)
  5. Rely on assert (details)
Commit 54c07f297f984e404e79b4dccd7a4cb0eff4f3dd by modelica
Set Evaluate = true for IdealTransformer.considerMagnetization

Leaving this parameter unevaluated seems like making things overly complicated, and as far as I can see there is nothing that clearly requires the parameter to be treated structurally.  Hence, adding an explicit annotation will increase chances of models being treated equally efficiently across tools.

Of course, I would have preferred to declare considerMagnetization a constant with Dialog annotation instead, but I'm afraid the general preference is to use a parameter with Evaluate = true instead.
The file was modified Modelica/Electrical/Analog/Ideal/IdealTransformer.mo (diff)
Commit 80b9eed0f27068d9b368b7b1a6244587bd1b6a25 by noreply
Make third-party licenses explicit (#4268)

The file was removedModelica/Resources/Licenses/LICENSE_c99-snprintf.txt
The file was removedModelica/Resources/Licenses/LICENSE_uthash.txt
The file was addedModelica/Resources/Licenses/Third-party/LICENSE_win32_dirent.txt
The file was addedModelica/Resources/Licenses/Third-party/LICENSE_stdint_msvc.txt
The file was removedModelica/Resources/Licenses/LICENSE_APHashFunction.txt
The file was addedModelica/Resources/Licenses/Third-party/LICENSE_c99-snprintf.txt
The file was addedModelica/Resources/Licenses/Third-party/LICENSE_APHashFunction.txt
The file was addedModelica/Resources/Licenses/Third-party/LICENSE_uthash.txt
The file was removedModelica/Resources/Licenses/LICENSE_win32_dirent.txt
The file was addedModelica/Resources/Licenses/Third-party/LICENSE_zlib.txt
The file was removedModelica/Resources/Licenses/LICENSE_portable-snippets.txt
The file was removedModelica/Resources/Licenses/LICENSE_zlib.txt
The file was addedModelica/Resources/Licenses/Third-party/LICENSE_portable-snippets.txt
The file was removedModelica/Resources/Licenses/LICENSE_stdint_msvc.txt
Commit fa90ce72720e3ffee385d1f5ab6081eb43637a94 by noreply
Utilize PressureSlope unit in Media consistently (#4262)

* Utilize PressureRate unit

* Rename PressureRate to PressureSlope
The file was modified Modelica/Media/Air/MoistAir.mo (diff)
The file was modified Modelica/Media/Water/IF97_Utilities.mo (diff)
The file was modified Modelica/Media/package.mo (diff)
The file was modified Modelica/Units.mo (diff)
Commit 68aa65640185537cd566c3739bbe81fd339651cb by noreply
Fix loss factors in SharpEdgedOrifice (#4258)

Co-authored-by: Stefan Wischhusen <wischhusen@xrg-simulation.de>
The file was modified Modelica/Fluid/Fittings.mo (diff)
Commit 0ab7e41a401444bc9a7f01264a0b4087044a0b2c by noreply
Rely on assert

Co-authored-by: Henrik Tidefelt <henrikt@wolfram.com>
The file was modified .CI/Test/Common.c (diff)

Summary

  1. Set Evaluate = true for IdealTransformer.considerMagnetization (details)
  2. Make third-party licenses explicit (#4268) (details)
  3. Utilize PressureSlope unit in Media consistently (#4262) (details)
  4. Fix loss factors in SharpEdgedOrifice (#4258) (details)
  5. Rely on assert (details)
Commit 54c07f297f984e404e79b4dccd7a4cb0eff4f3dd by modelica
Set Evaluate = true for IdealTransformer.considerMagnetization

Leaving this parameter unevaluated seems like making things overly complicated, and as far as I can see there is nothing that clearly requires the parameter to be treated structurally.  Hence, adding an explicit annotation will increase chances of models being treated equally efficiently across tools.

Of course, I would have preferred to declare considerMagnetization a constant with Dialog annotation instead, but I'm afraid the general preference is to use a parameter with Evaluate = true instead.
The file was modified Modelica/Electrical/Analog/Ideal/IdealTransformer.mo (diff)
Commit 80b9eed0f27068d9b368b7b1a6244587bd1b6a25 by noreply
Make third-party licenses explicit (#4268)

The file was addedModelica/Resources/Licenses/Third-party/LICENSE_win32_dirent.txt
The file was addedModelica/Resources/Licenses/Third-party/LICENSE_APHashFunction.txt
The file was addedModelica/Resources/Licenses/Third-party/LICENSE_zlib.txt
The file was removedModelica/Resources/Licenses/LICENSE_portable-snippets.txt
The file was addedModelica/Resources/Licenses/Third-party/LICENSE_stdint_msvc.txt
The file was removedModelica/Resources/Licenses/LICENSE_uthash.txt
The file was removedModelica/Resources/Licenses/LICENSE_stdint_msvc.txt
The file was addedModelica/Resources/Licenses/Third-party/LICENSE_portable-snippets.txt
The file was addedModelica/Resources/Licenses/Third-party/LICENSE_uthash.txt
The file was removedModelica/Resources/Licenses/LICENSE_APHashFunction.txt
The file was removedModelica/Resources/Licenses/LICENSE_c99-snprintf.txt
The file was removedModelica/Resources/Licenses/LICENSE_zlib.txt
The file was removedModelica/Resources/Licenses/LICENSE_win32_dirent.txt
The file was addedModelica/Resources/Licenses/Third-party/LICENSE_c99-snprintf.txt
Commit fa90ce72720e3ffee385d1f5ab6081eb43637a94 by noreply
Utilize PressureSlope unit in Media consistently (#4262)

* Utilize PressureRate unit

* Rename PressureRate to PressureSlope
The file was modified Modelica/Media/Air/MoistAir.mo (diff)
The file was modified Modelica/Units.mo (diff)
The file was modified Modelica/Media/Water/IF97_Utilities.mo (diff)
The file was modified Modelica/Media/package.mo (diff)
Commit 68aa65640185537cd566c3739bbe81fd339651cb by noreply
Fix loss factors in SharpEdgedOrifice (#4258)

Co-authored-by: Stefan Wischhusen <wischhusen@xrg-simulation.de>
The file was modified Modelica/Fluid/Fittings.mo (diff)
Commit 0ab7e41a401444bc9a7f01264a0b4087044a0b2c by noreply
Rely on assert

Co-authored-by: Henrik Tidefelt <henrikt@wolfram.com>
The file was modified .CI/Test/Common.c (diff)