Skip to content

Changes

Summary

  1. Remove bad simlification e1/tanh(e2) --> e1*cosh(e1)/sinh(e2) (details)
  2. Fix wrong simplification cos/tan => sin to sin/tan => cos (details)
  3. Always write a complete results file with Cpp runtime (details)
  4. Fix Cpp reduction for array, remove obsolete create/fill_array_from_shape (details)
  5. Fix Cpp reduction for record and add test (details)
  6. Update build-deps to v1.16.3 (new ca-certs) (#7957) (details)
  7. Use a newer docker image for cmake build (#7958) (details)
  8. Remove cmake-gcc pipeline (details)
  9. Fix Jenkins pipeline (#8113) (details)
Commit 9edce3b5785826c745c41cfd8752408121ea9b26 by rdgfranke
Remove bad simlification e1/tanh(e2) --> e1*cosh(e1)/sinh(e2)

This avoids two instead of one calls to builtin functions. It also
avoids potential numerical overflows for large values of e2 when sinh returns inf.
See: PowerSystems.Examples.AC3ph.Inverters.InverterToLoad
See also issue #8005.
The file was modified OMCompiler/Compiler/FrontEnd/ExpressionSimplify.mo (diff)
Commit 035dca68b53975be367d5fea89dc5ac714d698f3 by rdgfranke
Fix wrong simplification cos/tan => sin to sin/tan => cos
The file was modified OMCompiler/Compiler/FrontEnd/ExpressionSimplify.mo (diff)
Commit 2067331673cebb18346cd23fbaf21a4c9b6d877c by rdgfranke
Always write a complete results file with Cpp runtime

This simplifies the analysis of initialization errors
and it works around crashes of OMEdit,
see issue #8008 (OMEdit crashes if a simulation fails or is canceled).

- SimManager.cpp: write out values after initialization,
  also in case of failure for the analysis of intermediate results
- SolverDefaultImplementation: decouple writing of variable names
  from initialization of solver. Write them before first values instead.
The file was modified OMCompiler/SimulationRuntime/cpp/Include/Core/Solver/SolverDefaultImplementation.h (diff)
The file was modified OMCompiler/SimulationRuntime/cpp/Core/Solver/SolverDefaultImplementation.cpp (diff)
The file was modified OMCompiler/SimulationRuntime/cpp/Core/SimController/SimManager.cpp (diff)
Commit c829d34fc155230b9a0cb9447399a51c9d9ace8b by rdgfranke
Fix Cpp reduction for array, remove obsolete create/fill_array_from_shape

See ModelicaTest.Fluid.TestComponents.ModelicaTest.Fluid.TestComponents.Machines.TestWaterPumpCharacteristics
in particular pumpPolynomial using Modelica.Fluid.Machines.BaseClasses.PumpCharacteristics.polynomialFlow
The file was modified OMCompiler/SimulationRuntime/cpp/Core/Math/ArrayOperations.cpp (diff)
The file was modified OMCompiler/Compiler/Template/CodegenCppCommon.tpl (diff)
The file was modified OMCompiler/SimulationRuntime/cpp/Include/Core/Math/ArrayOperations.h (diff)
Commit 432352fc7d511f7fdfbc1a485414872d453b58b5 by rdgfranke
Fix Cpp reduction for record and add test

Remove special treatment to treat array of record as regular array.

Also remove idx_type, spec_type and getNextIndex from ArrayOperations
that are not used anymore since removal of create/fill_array_from_shape.
The file was modified testsuite/openmodelica/cppruntime/Makefile (diff)
The file was addedtestsuite/openmodelica/cppruntime/testReduction.mos
The file was modified OMCompiler/SimulationRuntime/cpp/Core/Math/ArrayOperations.cpp (diff)
The file was modified OMCompiler/Compiler/Template/CodegenCppCommon.tpl (diff)
The file was modified OMCompiler/SimulationRuntime/cpp/Include/Core/Math/ArrayOperations.h (diff)
Commit 84f3e9b28fb65e5d1bae5990ca169200cb951dc7 by Martin Sjölund
Update build-deps to v1.16.3 (new ca-certs) (#7957)

The file was modified .CI/cache/Dockerfile (diff)
The file was modified Jenkinsfile (diff)
Commit abd37b51a568007f0b57971a23afacdefbd4d58e by rdgfranke
Use a newer docker image for cmake build (#7958)

Xenial is outdated and the ca-certs no longer work.
# Conflicts:
# Jenkinsfile
resolved with accept both
The file was added.CI/cache-without-cmake/Dockerfile
The file was modified Jenkinsfile (diff)
Commit e8bef1407f91c21fb0a2915137927a6302cf9ed1 by Martin Sjölund
Remove cmake-gcc pipeline
The file was modified Jenkinsfile (diff)
Commit 281cb6ecec9ef9a6f020a54779865c55c5145422 by Martin Sjölund
Fix Jenkins pipeline (#8113)

A Jenkins update seems to have made restrictions to unstash. Remove
symbolic links before we stash omc-clang as a workaround.
The file was modified Jenkinsfile (diff)